Re: [PATCH 2/5] cpuset memory spread page cache implementation and hooks

[Andrew Morton <akpm@osdl.org>]

Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> Hmm... Make this
> 
> 
> static inline struct page *page_cache_alloc(struct address_space *x)
> {
> #ifdef CONFIG_NUMA
>  	if (cpuset_mem_spread_check()) {
>  		int n = cpuset_mem_spread_node();
>  		return alloc_pages_node(n, mapping_gfp_mask(x), 0);
>  	}
> #endif
>  	return alloc_pages(mapping_gfp_mask(x), 0);
> }

That's a no-op.

The problem remains that for CONFIG_NUMA=y, this function is too big to inline.

It's a minor thing.  But it's a thing.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/