Re: [PATCH] ibmasm driver: don't use previously freed pointer

On Fri, Feb 03, 2006 at 02:26:38PM -0800, Max Asbock wrote:
> ibmasm driver:
> Fix the command_put() function which uses a pointer for a spinlock that
> can be freed before dereferencing it.
> 
> Signed-off-by: Max Asbock [email protected]
> 
> ---
> 
> diff -burpN linux-2.6.16-rc1/drivers/misc/ibmasm/ibmasm.h linux-2.6.16-rc1.ibmasm/drivers/misc/ibmasm/ibmasm.h
> --- linux-2.6.16-rc1/drivers/misc/ibmasm/ibmasm.h	2006-02-01 11:50:01.000000000 -0800
> +++ linux-2.6.16-rc1.ibmasm/drivers/misc/ibmasm/ibmasm.h	2006-02-03 13:57:42.000000000 -0800
> @@ -101,10 +101,11 @@ struct command {
>  static inline void command_put(struct command *cmd)
>  {
>  	unsigned long flags;
> +	spinlock_t *lock = cmd->lock;
>  
> -	spin_lock_irqsave(cmd->lock, flags);
> +	spin_lock_irqsave(lock, flags);
>          kobject_put(&cmd->kobj);
> -	spin_unlock_irqrestore(cmd->lock, flags);
> +	spin_unlock_irqrestore(lock, flags);
>  }

If this patch is true, doesn't the spinlock the pointer is pointing out
still get deleted?

Yes you save a pointer off, but it looks like the problem is still
present.

Or am I missing something?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] ibmasm driver: don't use previously freed pointer
    • From: Max Asbock <[email protected]>

• References:
  • [PATCH] ibmasm driver: don't use previously freed pointer
    • From: Max Asbock <[email protected]>

• Prev by Date: Re: Altix SN2 2.6.16-rc1-mm5 build breakage (was: msi support)
• Next by Date: Re: [PATCH] ufs: fill i_size at directory creation
• Previous by thread: [PATCH] ibmasm driver: don't use previously freed pointer
• Next by thread: Re: [PATCH] ibmasm driver: don't use previously freed pointer
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]