Re: [ 01/10] [Suspend2] kernel/power/modules.h

["Rafael J. Wysocki" <rjw@sisk.pl>]

Hi,

On Wednesday 01 February 2006 23:55, Nigel Cunningham wrote:
> On Thursday 02 February 2006 07:45, Pekka Enberg wrote:
> > On Wednesday 01 February 2006 23:01, Pekka Enberg wrote:
> > > > I think we can call these suspend_{get|set}_modules instead i.e.
> > > > without the extra '2'.
> >
> > On 2/1/06, Nigel Cunningham <nigel@suspend2.net> wrote:
> > > I wanted to avoid confusion with similar routine names Pavel might use.
> > > For example, he has a resume_setup and I have a resume2_setup.
> >
> > Is that necessary for the mainline, though? We have only one suspend
> > in the kernel, not "Pavel suspend" and "Nigel suspend", right?
> 
> Well, I'd love that to be true, but I don't believe Pavel's going to roll over 
> and say "Ok Nigel. You've got a better implementation. I'll submit patches to 
> remove mine." I might be wrong, and I hope I will be, but I fear they're 
> going to coexist for a while.

First, your code introduces many changes in many parts of the kernel,
so to merge it you'll have to ask many people for acceptance.

Second, swsusp is actively developed, not only by Pavel, and you know that,
so you could be nicer. ;-)

Still our approach is quite different to yours.  We are focused on keepeing
the code possibly simple and non-intrusive wrt the other parts of the kernel,
whereas you seem to concentrate on features (which is not wrong, IMO, it's
just a different point of view).  We're moving towards the implementation
of the features like the system image compression and encryption,
graphical progress meters etc. in the user space, which has some advantages,
and I think this approach is correct for a laptop/desktop system.

Its limitation , however, is that it requires a lot of memory for the system
memory snapshot which may be impractical for systems with limited RAM,
and that's where your solution may be required.

In conclusion, I see the room for both, as long as the do not conflict, so
could we please bury the hatched and start working _together_?

Greetings,
Rafael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/