Re: [PATCH] pid: Don't hash pid 0.

Jan Engelhardt wrote:

@@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en
{
	struct pid *pid, *task_pid;

+	if (!nr)
+		goto out;
+

How about nr==0, it would make it more obvious.



Jan Engelhardt

I am inclined to agree. `!nr' seems to imply some sort of an error condition; perhaps a comment could be placed in order to make why the case of (nr == 0) is being ignored.

- Yuki.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] pid: Don't hash pid 0.
    • From: Jan Engelhardt <[email protected]>

• References:
  • [PATCH] pid: Don't hash pid 0.
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] pid: Don't hash pid 0.
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: Re: insmod error
• Next by Date: [PATCH RESEND] move swiotlb.h header file to asm-generic
• Previous by thread: Re: [PATCH] pid: Don't hash pid 0.
• Next by thread: Re: [PATCH] pid: Don't hash pid 0.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]