pid 0 is never exported to userspace, so hashing it servers no useful
purpose.
Explicitly not hashing pid 0 allows struct pid to be marked as not
hashed, and it allows us to avoid checks if for pid 0 when searching
for processes to signal if pid 0 does not have a special meaning.
Signed-off-by: Eric W. Biederman <[email protected]>
---
kernel/pid.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
da30e3ccb4b506b79fe0e6439addbfc763e92e24
diff --git a/kernel/pid.c b/kernel/pid.c
index d2247dc..7890867 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en
{
struct pid *pid, *task_pid;
+ if (!nr)
+ goto out;
+
task_pid = &task->pids[type];
pid = find_pid(type, nr);
task_pid->nr = nr;
@@ -159,7 +162,7 @@ int fastcall attach_pid(task_t *task, en
INIT_HLIST_NODE(&task_pid->pid_chain);
list_add_tail_rcu(&task_pid->pid_list, &pid->pid_list);
}
-
+ out:
return 0;
}
@@ -169,6 +172,9 @@ static fastcall int __detach_pid(task_t
int nr = 0;
pid = &task->pids[type];
+ if (!pid->nr)
+ goto out;
+
if (!hlist_unhashed(&pid->pid_chain)) {
if (list_empty(&pid->pid_list)) {
@@ -185,7 +191,7 @@ static fastcall int __detach_pid(task_t
list_del_rcu(&pid->pid_list);
pid->nr = 0;
-
+ out:
return nr;
}
--
1.1.5.g3480
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]