Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC

On Sat, Jan 14, 2006 at 07:24:09PM +0000, Alan Cox wrote:
> Some quick comments:
> 
> +       if (len) {
> +               epx_c3_pet();
> +       }
> 
> Doesn't need brackets (minor style)
> 
> Otherwise it looks excellent but should use request_region and friends
> to claim the two ports it uses.

It misses locking to protect against two concurrent writers in case of  
a shared /dev/wdt file-descriptor? 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Watchdog: Winsystems EPX-C3 SBC
    • From: "Calin A. Culianu" <[email protected]>
  • Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: [patch 1/2] rcu batch tuning
• Next by Date: Re: [parisc-linux] Re: [PATCH 3/6] C-language equivalents of include/asm-*/bitops.h
• Previous by thread: Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
• Next by thread: [ANNOUNCE] GIT 1.1.2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]