Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC

Some quick comments:

+       if (len) {
+               epx_c3_pet();
+       }

Doesn't need brackets (minor style)

Otherwise it looks excellent but should use request_region and friends
to claim the two ports it uses.

The see the "Sign your work:" bit of Documentation/SubmittingPatches are
it looks ready to go in.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
    • From: Marcelo Tosatti <[email protected]>
  • Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
    • From: Willy Tarreau <[email protected]>

• References:
  • [PATCH] Watchdog: Winsystems EPX-C3 SBC
    • From: "Calin A. Culianu" <[email protected]>

• Prev by Date: Re: [?] PCI BIOS masks some IDs to prevent OS detection?
• Next by Date: 2.6.15: lm90 0-004c: Register 0x13 read failed (-1)
• Previous by thread: [PATCH] Watchdog: Winsystems EPX-C3 SBC
• Next by thread: Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]