Re: [PATCH 5/5] file: Modify struct fown_struct to contain a tref

Suleiman Souhlal <[email protected]> writes:

> Eric W. Biederman wrote:
>
>> @@ -317,7 +326,9 @@ static long do_fcntl(int fd, unsigned in
>>  		 * current syscall conventions, the only way
>>  		 * to fix this will be in libc.
>>  		 */
>> -		err = filp->f_owner.pid;
>> +		err = 0;
>> +		if (filp->f_owner.tref->task)
>> +			err = filp->f_owner.pid;
>
> Probably not very important, but why don't you use
> filp->f_owner.tref->task->pid? This way you could completely get rid of the pid
> field in fown_struct.

Two reasons.
One because task->pid is not the proper value for a thread group.
And because task might be NULL.

Basically using filp->f_owner.tref->task->pid as my source is a much
more complicated expression.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 0/5] Task references..
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 1/5] pid: Implement task references.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 2/5] pid: Add macros for interating through tasks by type.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 3/5] pid: Implement kill_tref.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 4/5] vt: Update spawnpid to use a task_ref.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 5/5] file: Modify struct fown_struct to contain a tref
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 5/5] file: Modify struct fown_struct to contain a tref
    • From: Suleiman Souhlal <[email protected]>

• Prev by Date: Re: [PATCH] ahci: get JMicron JMB360 working
• Next by Date: [PATCH] Documentation/stable_kernel_rules.txt: Clarification
• Previous by thread: Re: [PATCH 5/5] file: Modify struct fown_struct to contain a tref
• Next by thread: Re: [PATCH 4/5] vt: Update spawnpid to use a task_ref.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]