Re: [PATCH 5/5] file: Modify struct fown_struct to contain a tref

Eric W. Biederman wrote:

@@ -317,7 +326,9 @@ static long do_fcntl(int fd, unsigned in
 		 * current syscall conventions, the only way
 		 * to fix this will be in libc.
 		 */
-		err = filp->f_owner.pid;
+		err = 0;
+		if (filp->f_owner.tref->task)
+			err = filp->f_owner.pid;

Probably not very important, but why don't you use filp->f_owner.tref->task->pid? This way you could completely get rid of the pid field in fown_struct.

--- a/net/socket.c
+++ b/net/socket.c
@@ -855,7 +855,10 @@ static long sock_ioctl(struct file *file
 			break;
 		case FIOGETOWN:
 		case SIOCGPGRP:
-			err = put_user(sock->file->f_owner.pid, (int __user *)argp);
+			pid = 0;
+			if (sock->file->f_owner.tref->task)
+				pid = sock->file->f_owner.pid;
+			err = put_user(pid, (int __user *)argp);

Same here.

-- Suleiman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/5] file: Modify struct fown_struct to contain a tref
    • From: [email protected] (Eric W. Biederman)

• References:
  • [RFC][PATCH 0/5] Task references..
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 1/5] pid: Implement task references.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 2/5] pid: Add macros for interating through tasks by type.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 3/5] pid: Implement kill_tref.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 4/5] vt: Update spawnpid to use a task_ref.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 5/5] file: Modify struct fown_struct to contain a tref
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: [PATCH] exec: Only allow a threaded init to exec from the thread_group_leader
• Next by Date: Re: [PATCH 1/5] pid: Implement task references.
• Previous by thread: [PATCH 5/5] file: Modify struct fown_struct to contain a tref
• Next by thread: Re: [PATCH 5/5] file: Modify struct fown_struct to contain a tref
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]