Re: [PATCH 04/04] Add dsa key type

[David Härdeman <david@2gen.com>]

On Tue, Jan 24, 2006 at 11:08:45AM +0000, David Howells wrote:
> David Härdeman <david@2gen.com> wrote:
>
> > Adds the dsa in-kernel key type.
>
> Please add a header file in include/keys/ to provide access to the key type
> definition and any special payload structures you use.

That was already added by one of the earlier patches as include/dsa.h 
since its shared by crypto/dsa.c and security/keys/dsa_key.c, do you 
prefer some other solution?

> > +static char *
> > +sign(const struct key_payload_dsa *skey, 
>
> Please be consistent about sticking prefixes on the names of your
> functions. This ought to be called something like dsa_sign.

Ok

> > +		printk("dsa: crypto_digest_setkey failed with error %i\n", i);
>
> Should involve KERN_ERR or something like.

Ok

Regards,
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/