Re: [PATCH 04/04] Add dsa key type

David Härdeman <[email protected]> wrote:

> Adds the dsa in-kernel key type.

Please add a header file in include/keys/ to provide access to the key type
definition and any special payload structures you use.

> +static char *
> +sign(const struct key_payload_dsa *skey, 

Please be consistent about sticking prefixes on the names of your
functions. This ought to be called something like dsa_sign.

> +		printk("dsa: crypto_digest_setkey failed with error %i\n", i);

Should involve KERN_ERR or something like.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 04/04] Add dsa key type
    • From: David Howells <[email protected]>
  • Re: [PATCH 04/04] Add dsa key type
    • From: David Härdeman <[email protected]>

• References:
  • [PATCH 04/04] Add dsa key type
    • From: David Härdeman <[email protected]>

• Prev by Date: Re: Rationale for RLIMIT_MEMLOCK?
• Next by Date: Re: [PATCH] shrink_dcache_parent() races against shrink_dcache_memory()
• Previous by thread: [PATCH 04/04] Add dsa key type
• Next by thread: Re: [PATCH 04/04] Add dsa key type
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]