On Jan 14, 2006, at 9:18 PM, Ulrich Drepper wrote:
On 1/14/06, david singleton <[email protected]> wrote:can you suggest some error codes you like to use? I'll use whatever you suggest.How about EADDRNOTAVAIL. The error message kind of makes sense, even though "address" is misused. And there definitely won't be a clash with other error codes because it's currently only used in network contexts.
Ulrich,I've fixed another memory leak in free_robust_list. The entries in the slab caches now look correct through the full test suite up to 7500 threads. Does your glibc
work correctly with this patch? diff -u linux-2.6.15/kernel/futex.c linux-2.6.15/kernel/futex.c --- linux-2.6.15/kernel/futex.c +++ linux-2.6.15/kernel/futex.c @@ -917,6 +917,8 @@ up(&mapping->robust_head->robust_sem); kmem_cache_free(file_futex_cachep, futex_head); + mapping->robust_head = NULL; + return; } The new full patch is attached, and at http://source.mvista.com/~dsingleton/robust–futex-3 David
Attachment:
robust-futex-3
Description: Binary data
- Follow-Ups:
- Re: [robust-futex-3] futex: robust futex support
- From: Ulrich Drepper <[email protected]>
- Re: [robust-futex-3] futex: robust futex support
- From: Ulrich Drepper <[email protected]>
- Re: [robust-futex-3] futex: robust futex support
- References:
- [robust-futex-1] futex: robust futex support
- From: David Singleton <[email protected]>
- Re: [robust-futex-1] futex: robust futex support
- From: Ulrich Drepper <[email protected]>
- Re: [robust-futex-1] futex: robust futex support
- From: david singleton <[email protected]>
- Re: [robust-futex-1] futex: robust futex support
- From: Ulrich Drepper <[email protected]>
- [robust-futex-1] futex: robust futex support
- Prev by Date: Re: [patch] mm: Convert global dirty_exceeded flag to per-node node_dirty_exceeded
- Next by Date: Re: [patch 6/6] serial8250: convert to the new platform device interface
- Previous by thread: Re: [robust-futex-1] futex: robust futex support
- Next by thread: Re: [robust-futex-3] futex: robust futex support
- Index(es):