Re: [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2

[Dmitry Torokhov <dtor_core@ameritech.net>]

On Saturday 14 January 2006 11:21, Faidon Liambotis wrote:
> Ingo Molnar wrote:
> > @@ -1371,11 +1373,11 @@ static ssize_t psmouse_attr_set_protocol
> >  			return -EIO;
> >  		}
> >  
> > -		up(&psmouse_sem);
> > +		mutex_unlock(&psmouse_mutex);
> >  		serio_unpin_driver(serio);
> >  		serio_unregister_child_port(serio);
> >  		serio_pin_driver_uninterruptible(serio);
> > -		down(&psmouse_sem);
> > +		mutex_lock(&psmouse_mutex);
> Isn't that supposed to be the other way around?
> 

No, that's correct. We temporarily dropping the lock to let the serio core
do its job and then reaqcuire it again to finish what we were doing. 

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/