Re: [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2

Ingo Molnar wrote:
> @@ -1371,11 +1373,11 @@ static ssize_t psmouse_attr_set_protocol
>  			return -EIO;
>  		}
>  
> -		up(&psmouse_sem);
> +		mutex_unlock(&psmouse_mutex);
>  		serio_unpin_driver(serio);
>  		serio_unregister_child_port(serio);
>  		serio_pin_driver_uninterruptible(serio);
> -		down(&psmouse_sem);
> +		mutex_lock(&psmouse_mutex);
Isn't that supposed to be the other way around?

Regards,
Faidon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2
    • From: Dmitry Torokhov <[email protected]>

• References:
  • [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [patch] kobject: don't oops on null kobject.name
• Next by Date: Re: [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2
• Previous by thread: [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2
• Next by thread: Re: [patch 2.6.15-mm4] sem2mutex: drivers/input/, #2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]