Re: [RFC/RFT][PATCH -mm] swsusp: userland interface

[Ingo Oeser <ioe-lkml@rameria.de>]

Hi,

On Friday 13 January 2006 00:31, Rafael J. Wysocki wrote:
> On Thursday, 12 January 2006 23:09, Pavel Machek wrote:
> > > +SNAPSHOT_IOCAVAIL_SWAP - check the amount of available swap (the last argument
> > > +	should be a pointer to an unsigned int variable that will contain
> > > +	the result if the call is successful)
> > 
> > Is this good idea? It will overflow on 32-bit systems. Ammount of
> > available swap can be >4GB. [Or maybe it is in something else than
> > bytes, then you need to specify it.]
> 
> It returns the number of pages.  Well, it should be written explicitly,
> so I'll fix that.

Please always talk to the kernel in bytes. Pagesize is only a kernel
internal unit. Sth. like off64_t is fine.


Regards

Ingo Oeser

Attachment: pgpl9612KOyZS.pgp
Description: PGP signature