Re: [RFC/RFT][PATCH -mm] swsusp: userland interface

[Pavel Machek <pavel@ucw.cz>]

Hi!

> This is the next version of the patch that adds a user space interface to
> swsusp.

Looks mostly okay, few nits...

> +	case SNAPSHOT_IOCFREEZE:

Could we make it SNAPSHOT_IOC_FREEZE or even better SNAPSHOT_FREEZE?

> +commands defined in kernel/power/power.h.  The major and minor
> +numbers of the device are, respectively, 10 and 231, and they can
> +be read from /sys/class/misc/snapshot/dev.

Is this still true?

> +The device can be open either for reading or for writing.  If open for
> +reading, it is considered to be in the suspend mode.  Otherwise it is
> +assumed to be in the resume mode.  The device cannot be open for reading
> +and writing.  It is also imposiible to have the device open more
                            ~~~~~~~~~~
				typo.

> +SNAPSHOT_IOCSET_IMAGE_SIZE - set the preferred maximum size of the image
> +	(the kernel will do its best to ensure the image size will not exceed
> +	this number, but if it turns out to be impossible, the kernel will
> +	create the smallest image possible)

Nice.

> +SNAPSHOT_IOCAVAIL_SWAP - check the amount of available swap (the last argument
> +	should be a pointer to an unsigned int variable that will contain
> +	the result if the call is successful)

Is this good idea? It will overflow on 32-bit systems. Ammount of
available swap can be >4GB. [Or maybe it is in something else than
bytes, then you need to specify it.]

> +SNAPSHOT_IOCSET_SWAP_FILE - set the resume partition (the last ioctl() argument
> +	should specify the device's major and minor numbers in the old
> +	two-byte format, as returned by the stat() function in the .st_rdev
> +	member of the stat structure); it is recommended to always use this
> +	call, because the other code the could have set the resume partition
> +	need not be present in the kernel

Parse error on last sentence.

"because the code to set the resume partition could be removed from
future kernels"?

> +For details, please refer to the source code.

We should specify that userland suspend/resume utilities should lock
themselves in memory before freezing system, and not attempt
filesystem operations after freeze. (Probably not even reads).

We may want to specify if it is okay to snapshot system and then
unfreeze and continue. I'd suggest supporting that -- it will be handy
for "esc to abort" and "suspend to RAM and disk".

Ouch and you have my ACK on next attempt :-).
								Pavel
-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/