Re: [PATCH 01/17] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id()

Hi there,

On Friday 13 January 2006 03:37, Chris Wright wrote:
> One of the conversions from memcmp to compare_ether_addr is incorrect.
> We need to do relative comparison to determine min MAC address to
> use in bridge id. This will cause the wrong bridge id to be chosen
> which violates 802.1d Spanning Tree Protocol, and may create forwarding
> loops.

Why not include a shorter version of this nice explanation
above the list_for_each_entry() loop?

Like:

/* We try to find the min MAC address to use in this bridge id. */

This will prevent the next janitor from converting this again
which avoids future regressions here.

What do you think?


Regards

Ingo Oeser

Attachment: pgpKKkeLHvs6V.pgp
Description: PGP signature

---

• Follow-Ups:
  • Re: [PATCH 01/17] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id()
    • From: Chris Wright <[email protected]>

• References:
  • [PATCH 00/17] -stable review
    • From: Chris Wright <[email protected]>
  • [PATCH 01/17] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id()
    • From: Chris Wright <[email protected]>

• Prev by Date: Re: Dual core Athlons and unsynced TSCs
• Next by Date: Re: 2.6.15-ck1
• Previous by thread: [PATCH 01/17] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id()
• Next by thread: Re: [PATCH 01/17] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]