Re: [PATCH] reiserfs: use __GFP_NOFAIL instead of yield and retry loop for allocation

[Pekka J Enberg <penberg@cs.Helsinki.FI>]

Hi,

Pekka J Enberg <penberg@cs.Helsinki.FI> wrote:
> >
> >  -      retry:
> >  -	jl = kzalloc(sizeof(struct reiserfs_journal_list), GFP_NOFS);
> >  -	if (!jl) {
> >  -		yield();
> >  -		goto retry;
> >  -	}
> >  +	jl = kzalloc(sizeof(struct reiserfs_journal_list),
> >  +		     GFP_NOFS | __GFP_NOFAIL);

On Thu, 12 Jan 2006, Andrew Morton wrote:
> yup, that's what __GFP_NOFAIL is for: to consolidate and identify all those
> places which want to lock up when we're short of memory...  They all need
> fixing, really.

Out of curiosity, are there any potential problems with combining GFP_NOFS 
and __GFP_NOFAIL? Can we really guarantee to give out memory if we're not 
allowed to page out?

			Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/