Re: [PATCH] reiserfs: use __GFP_NOFAIL instead of yield and retry loop for allocation

Pekka J Enberg <[email protected]> wrote:
>
>  -      retry:
>  -	jl = kzalloc(sizeof(struct reiserfs_journal_list), GFP_NOFS);
>  -	if (!jl) {
>  -		yield();
>  -		goto retry;
>  -	}
>  +	jl = kzalloc(sizeof(struct reiserfs_journal_list),
>  +		     GFP_NOFS | __GFP_NOFAIL);

yup, that's what __GFP_NOFAIL is for: to consolidate and identify all those
places which want to lock up when we're short of memory...  They all need
fixing, really.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] reiserfs: use __GFP_NOFAIL instead of yield and retry loop for allocation
    • From: Pekka J Enberg <[email protected]>

• References:
  • [PATCH] reiserfs: use __GFP_NOFAIL instead of yield and retry loop for allocation
    • From: Pekka J Enberg <[email protected]>

• Prev by Date: Re: [PATCH] reiserfs: remove kmalloc wrapper
• Next by Date: Re: [PATCH] reiserfs: remove kmalloc wrapper
• Previous by thread: [PATCH] reiserfs: use __GFP_NOFAIL instead of yield and retry loop for allocation
• Next by thread: Re: [PATCH] reiserfs: use __GFP_NOFAIL instead of yield and retry loop for allocation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]