Re: Lockups while unpacking huge tarballs (was Re: 2.6.15-$SHA1: VT <-> X sometimes odd)

[Jens Axboe <axboe@suse.de>]

On Thu, Jan 12 2006, Alexey Dobriyan wrote:
> On Thu, Jan 12, 2006 at 11:23:54AM -0800, Linus Torvalds wrote:
> > On Thu, 12 Jan 2006, Alexey Dobriyan wrote:
> > > Now it's vim saving 5k proggie while X tarball was unpacking on reiserfs.
> > > :wq and vim freezes. Switching to another virtual "desktops" works and
> > > everything in general works except vim. But switching to VT and back
> > > sends system to hell.
> >
> > This may be fixed by the current -git tree:
> >
> > 	commit 1bc691d3, Tejun Heo <htejun@gmail.com>:
> >
> > 	[PATCH] fix queue stalling while barrier sequencing
> 
> It isn't. My HEAD is 9f5974c8734d83d4ab7096ed98136a82f41210d6 and I see
> this patch in git log output.
> 
> > or if that isn't it, and you have an IDE drive, can you try if the
> > appended trivial patch makes a difference?
> 
> > --- a/drivers/ide/ide-io.c
> > +++ b/drivers/ide/ide-io.c
> > @@ -101,7 +101,7 @@ int __ide_end_request(ide_drive_t *drive
> >  	 * for those
> >  	 */
> >  	nbytes = nr_sectors << 9;
> > -	if (!rq->errors && rq_all_done(rq, nbytes)) {
> > +	if (0 && !rq->errors && rq_all_done(rq, nbytes)) {
> >  		rq->data_len = nbytes;
> >  		blkdev_dequeue_request(rq);
> >  		HWGROUP(drive)->rq = NULL;
> 
> With this one-liner two X tarballs and one Firefox tarballs were
> successfully unpacked while I was hitting :w.
> 
> Without it just one X tarball doesn't pass. It's even reproducable.

Alright thanks for retesting, current git should work for you (once it
mirrors out from master).

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/