Re: [PATCH]trivial: add CDC_RAM to ide-cd capabilities mask

[Chuck Ebbert <76306.1226@compuserve.com>]

In-Reply-To: <20060110101346.GO3389@suse.de>

On Tue, 10 Jan 2006, Jens Axboe wrote:

> On Mon, Jan 09 2006, Andrey Borzenkov wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Add CDC-RAM to capability mask. This prevents udev incorrectly reporting RAM 
> > capabilities for device.
> > 
> > Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
> > 
> > - ---
> > 
> > - --- linux-2.6.15/drivers/ide/ide-cd.c.orig        2006-01-03 06:21:10.000000000 +0300
> > +++ linux-2.6.15/drivers/ide/ide-cd.c       2006-01-09 00:31:32.000000000 +0300
> > @@ -2905,6 +2905,8 @@ static int ide_cdrom_register (ide_drive
> >             devinfo->mask |= CDC_CLOSE_TRAY;
> >     if (!CDROM_CONFIG_FLAGS(drive)->mo_drive)
> >             devinfo->mask |= CDC_MO_DRIVE;
> > +   if (!CDROM_CONFIG_FLAGS(drive)->ram)
> > +           devinfo->mask |= CDC_RAM;
> >  
> >     devinfo->disk = info->disk;
> >     return register_cdrom(devinfo);
> 
> Thanks, patch is correct.


 There are more problems in that area:

An ancient SCSI CD-ROM reports:

drive name:             sr0
drive speed:            1
drive # of slots:       1
Can close tray:         1
Can open tray:          1
Can lock tray:          1
Can change speed:       0
Can select disk:        0
Can read multisession:  1
Can read MCN:           1
Reports media changed:  1
Can play audio:         1
Can write CD-R:         0
Can write CD-RW:        0
Can read DVD:           0
Can write DVD-R:        0
Can write DVD-RAM:      0
Can read MRW:           1
Can write MRW:          1
Can write RAM:          1

There's no way this drive knows anything about MRW or random-access writing:

[   15.178959]   Vendor: NEC       Model: CD-ROM DRIVE:464  Rev: 1.04
[   15.200086]   Type:   CD-ROM                             ANSI SCSI revision: 02
...
[   16.621463] sr0: scsi-1 drive


And an ATAPI DVD-ROM also reports (before the above patch):

Can read MRW:           1
Can write MRW:          1
Can write RAM:          1


-- 
Chuck
Currently reading: _Olympos_ by Dan Simmons
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/