Re: [Patch] New zone ZONE_EASY_RECLAIM take 4. (disable gfp_easy_reclaim bit)[5/8]

[mel@csn.ul.ie (Mel Gorman)]

On (05/01/06 14:43), Yasunori Goto didst pronounce:
> > 
> > > ===================================================================
> > > --- zone_reclaim.orig/fs/pipe.c	2005-12-16 18:36:20.000000000 +0900
> > > +++ zone_reclaim/fs/pipe.c	2005-12-16 19:15:35.000000000 +0900
> > > @@ -284,7 +284,7 @@ pipe_writev(struct file *filp, const str
> > >  			int error;
> > >  
> > >  			if (!page) {
> > > -				page = alloc_page(GFP_HIGHUSER);
> > > +				page = alloc_page(GFP_HIGHUSER & ~__GFP_EASY_RECLAIM);
> > >  				if (unlikely(!page)) {
> > >  					ret = ret ? : -ENOMEM;
> > >  					break;
> > 
> > That is a bit hard to understand.  How about a new GFP_HIGHUSER_HARD or 
> > somesuch define back in patch 1, then use it here?
> 
> It looks better. Thanks for your idea.
> 

There are other places where GFP_HIGHUSER is used for pages that are not easily
reclaimed. It is easier clearer to add __GFP_EASY_RECLAIM at the places you
know pages are easily reclaimed rather than removing __GFP_EASY_RECLAIM from
awkward places.

-- 
Mel Gorman
Part-time Phd Student
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/