Re: [patch 2.6.15] i386: Optimize local APIC timer interrupt code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In-Reply-To: <[email protected]>

On Thu, 5 Jan 2006 at 07:03:14 +0100, Willy Tarreau wrote:

> +     if (likely(--per_cpu(prof_counter, cpu)) <= 0) {
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
are you sure about this ? it looks suspicious to me. I would have
expected something like  this instead :

+       if (likely(--per_cpu(prof_counter, cpu) <= 0)) {


  Nice catch, proving yet again the value of posting code for review!


-- 
Chuck
Currently reading: _Thud!_ by Terry Pratchett
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux