Re: [PATCH] [RFC] Optimize select/poll by putting small data sets on the stack

Arnd Bergmann a écrit :

Interestingly, doing a diff between sys_select and compat_sys_select
in the current kernel seems to suggest that they are both buggy
in that they miss checks for failing __put_user, but in /different/
places.

And I would like to pinpoint that set_fd_set() implementation seems *buggy* :

It should not use __copy_to_user() but the real one (copy_to_user()) because the calling thread could have slept in do_select() and another thread played mm games during this sleep.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] [RFC] Optimize select/poll by putting small data sets on the stack
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] [RFC] Optimize select/poll by putting small data sets on the stack
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] [RFC] Optimize select/poll by putting small data sets on the stack
    • From: Arnd Bergmann <[email protected]>

• Prev by Date: Re: [PATCH 8/11] Time: i386 Conversion - part 4: ACPI PM variable renaming and config change.
• Next by Date: Re: [Patch 6/6] Delay accounting: Connector interface
• Previous by thread: Re: [PATCH] [RFC] Optimize select/poll by putting small data sets on the stack
• Next by thread: Re: [PATCH] [RFC] Optimize select/poll by putting small data sets on the stack
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]