> > +int ipath_mlock(unsigned long start_page, size_t num_pages, struct page **p)
> OK. It's perhaps not a very well named function.
Really? Suggestion for a better name?
> > + }
> > + vm->vm_flags |= VM_SHM | VM_LOCKED;
> > +
> > + return 0;
> > +}
>
> I don't think we want to be setting the user's VMA's vm_flags in this
> manner. This is purely to retain the physical page across fork?
I didn't write this bit of the driver, but I believe this is the case.
Is there a better way of doing this?
> > +int ipath_munlock(size_t num_pages, struct page **p)
> > +{
> > + int i;
> > +
> > + for (i = 0; i < num_pages; i++) {
> > + _IPATH_MMDBG("%u/%lu put_page %p\n", i, num_pages, p[i]);
> > + SetPageDirty(p[i]);
> > + put_page(p[i]);
> > + }
> > + return 0;
> > +}
>
> Nope, SetPageDirty() doesn't tell the VM that the page is dirty - it'll
> never get written out. Use set_page_dirty_lock().
OK.
Regards,
Robert.
--
Robert Walsh Email: [email protected]
PathScale, Inc. Phone: +1 650 934 8117
2071 Stierlin Court, Suite 200 Fax: +1 650 428 1969
Mountain View, CA 94043.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
