On Thu, 2005-12-15 at 08:28 -0800, Linus Torvalds wrote: > I would suggest that if you create a new "mutex" type, you just keep the > lower-case name. Don't re-use the DECLARE_MUTEX format, just do > > struct mutex my_mutex = UNLOCKED_MUTEX; > > for new code that uses the new stuff. > > Think about it a bit. We don't have DECLARE_SPINLOCK either. Why? Well, we have DEFINE_SPINLOCK() and we should have a matching one for mutexes DEFINE_MUTEX(). The reason is that you can implement complex initialization for debugging or extensions which can't be done by a var = INITIALZER, because you dont have a reference to var. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Nikita Danilov <nikita@clusterfs.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Alan Cox <alan@lxorguk.ukuu.org.uk>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: David Howells <dhowells@redhat.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Paul Jackson <pj@sgi.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Paul Jackson <pj@sgi.com>
- [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: David Howells <dhowells@redhat.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Andrew Morton <akpm@osdl.org>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Christoph Hellwig <hch@infradead.org>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: David Howells <dhowells@redhat.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: David Howells <dhowells@redhat.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: David Howells <dhowells@redhat.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Thomas Gleixner <tglx@linutronix.de>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Mark Lord <lkml@rtr.ca>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Andrew Morton <akpm@osdl.org>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Nikita Danilov <nikita@clusterfs.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Alan Cox <alan@lxorguk.ukuu.org.uk>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: David Howells <dhowells@redhat.com>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- Prev by Date: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- Next by Date: SATA feature list available
- Previous by thread: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- Next by thread: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
- Index(es):
 |