Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Thu, 15 Dec 2005, Al Viro wrote:

> Move the sanity check for NR_IRQS being no more than 1<<HARDIRQ_BITS
> from asm-m68k/hardirq.h to asm-m68k/irq.h; needed since NR_IRQS is
> not necessary know at the points of inclusion of asm/hardirq.h due
> to the rather ugly header dependencies on m68k.  Fix is by far simpler
> than trying to massage those dependencies...

I disagree.

> diff --git a/include/asm-m68k/hardirq.h b/include/asm-m68k/hardirq.h
> index 728318b..5e1c582 100644
> --- a/include/asm-m68k/hardirq.h
> +++ b/include/asm-m68k/hardirq.h
> @@ -14,13 +14,4 @@ typedef struct {
>  
>  #define HARDIRQ_BITS	8
>  
> -/*
> - * The hardirq mask has to be large enough to have
> - * space for potentially all IRQ sources in the system
> - * nesting on a single CPU:
> - */
> -#if (1 << HARDIRQ_BITS) < NR_IRQS
> -# error HARDIRQ_BITS is too low!
> -#endif
> -
>  #endif

You separate the definition from the check, now you push the 
responsibility to get the order right to the header users.
Sorry, but I prefer to fix the header dependencies than scatter things 
which belong together over multiple files.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/