Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()

Andi Kleen a écrit :

On Wed, Dec 07, 2005 at 04:35:18PM +0100, Eric Dumazet wrote:

As reported by Keith Mannthey, there are problems in populate_memnodemap()

The bug was that the compute_hash_shift() was returning 31, with incorrect initialization of memnodemap[]

To correct the bug, we must use (1UL << shift) instead of (1 << shift) to avoid an integer overflow, and we must check that shift < 64 to avoid an infinite loop.

It's already merged, no need to resubmit. P.S.: It would be easier
to merge if you didn't use attachments.

Hi Andi

AFAIK I posted the patch on linux-kernel only once... and once privatly to Keith because it seems he missed the linux-kernel post.

I'm confused by your answer.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
    • From: Eric Dumazet <[email protected]>
  • Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: set_page_dirty vs set_page_dirty_lock
• Next by Date: Re: Semantics of smp_mb() [was : Re: [PATCH] Fix RCU race in access of nohz_cpu_mask ]
• Previous by thread: Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
• Next by thread: wrong number of serial port detected
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]