[PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()

As reported by Keith Mannthey, there are problems in populate_memnodemap()

The bug was that the compute_hash_shift() was returning 31, with incorrect initialization of memnodemap[]

To correct the bug, we must use (1UL << shift) instead of (1 << shift) to avoid an integer overflow, and we must check that shift < 64 to avoid an infinite loop.

Signed-off-by: Eric Dumazet <[email protected]>

--- linux-2.6.15-rc5/arch/x86_64/mm/numa.c	2005-12-04 06:10:42.000000000 +0100
+++ linux-2.6.15-rc5-ed/arch/x86_64/mm/numa.c	2005-12-07 16:45:15.000000000 +0100
@@ -53,6 +53,8 @@
 	int res = -1;
 	unsigned long addr, end;
 
+	if (shift >= 64)
+		return -1;
 	memset(memnodemap, 0xff, sizeof(memnodemap));
 	for (i = 0; i < numnodes; i++) {
 		addr = nodes[i].start;
@@ -65,7 +67,7 @@
 			if (memnodemap[addr >> shift] != 0xff)
 				return -1;
 			memnodemap[addr >> shift] = i;
-			addr += (1 << shift);
+                       addr += (1UL << shift);
 		} while (addr < end);
 		res = 1;
 	} 

---

• Follow-Ups:
  • Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
    • From: Andi Kleen <[email protected]>

• Prev by Date: RE: stat64 for over 2TB file returned invalid st_blocks
• Next by Date: Re: [linux-usb-devel] Re: [PATCH 00/10] usb-serial: Switches from spin lock to atomic_t.
• Previous by thread: [PATCH] support for Posiflex PP-7000 retail printer for ftdi_sio driver
• Next by thread: Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]