Re: [PATCH] Decrease number of pointer derefs in nfnetlink_queue.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David S. Miller wrote:
From: Jesper Juhl <[email protected]>
Date: Thu, 8 Dec 2005 23:36:01 +0100


Here's a small patch to decrease the number of pointer derefs in
net/netfilter/nfnetlink_queue.c

Benefits of the patch:
- Fewer pointer dereferences should make the code slightly faster.
- Size of generated code is smaller
- improved readability


And you verified the compiler isn't making these transformations
already?

Didn't the provided size(1) output would verify this?

In any case, I like the changes because it makes the code more readable, with the smaller code size as a pleasant side effect. Due to increase readability, I would only be inclined to NAK if the code performance/size was adversely effected.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux