Re: [PATCH] Fix RCU race in access of nohz_cpu_mask

Srivatsa Vaddagiri <[email protected]> wrote:
>
> +		smp_mb();
> +		cpus_andnot(rsp->cpumask, cpu_online_map, nohz_cpu_mask);

Please always include a comment when adding a barrier.  Because it's often
not obvious to the reader what that barrier is actually doing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix RCU race in access of nohz_cpu_mask
    • From: Srivatsa Vaddagiri <[email protected]>

• Prev by Date: Re: [RFC 1/3] Framework for accurate node based statistics
• Next by Date: Re: [PATCH] swap migration: Fix lru drain
• Previous by thread: [PATCH] Fix RCU race in access of nohz_cpu_mask
• Next by thread: Re: [PATCH] Fix RCU race in access of nohz_cpu_mask
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]