On Tue, Nov 22, 2005 at 09:43:46AM -0700, Matthew Wilcox wrote:
> > Please put the definition into <asm/irq.h> and <linux/interrupt.h>,
> > hardirq.h is rather misnamed and about the internal irq/softirq/preempt
> > mask mechanisms.
>
> Either you're wrong or I'm confused. I don't see the include path which
> necessarily drags asm/irq.h in from linux/interrupt.h. There's a
> linux/interrupt.h -> linux/hardirq.h -> asm/hardirq.h path, but not all
> asm/hardirq.h files drag in asm/irq.h. Look at sparc64 or alpha for
> examples of that.
Indeed. But that still doesn't mean we should pollute <linux/hardirq.h>
with it..
> Personally, I'd like to see asm/hardirq.h go away and move all its
> contents into asm/irq.h. And I'd like to see asm/irq.h included
> explicitly from linux/interrupt.h. And I'd like to see drivers stop
> including asm/irq.h.
Agreed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
