Re: [patch] warn-on-once.patch

On Sat 26. of November 2005 15:52 Ingo Molnar wrote:
> - introduce WARN_ON_ONCE(cond)
> [...]
> +#define WARN_ON_ONCE(condition)		\
> +do {					\
> +	static int warn_once = 1;	\
> +					\
> +	if (condition) {		\
> +		warn_once = 0;		\
> +		WARN_ON(1);		\
> +	}				\
> +} while (0);
> +
>  #endif

That can't be right. The variable warn_once is only written to. Should the 
condition be: if (condition && warn_once)  ?
Or even better with inverted logic (so that the variable is initialized to 0):

static int warned_once;
if (condition && !warned_once) {
	warned_once = 1;
	WARN_ON(1);
}


Michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/13] Time: Generic Timeofday Subsystem (v B11)
    • From: john stultz <[email protected]>
  • [PATCH 1/13] Time: Reduced NTP rework (part 1)
    • From: john stultz <[email protected]>
  • [patch] warn-on-once.patch
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [PATCH 0/13] Time: Generic Timeofday Subsystem (v B11)
• Next by Date: Re: [patch] warn-on-once.patch
• Previous by thread: [patch] warn-on-once.patch
• Next by thread: Re: [patch] warn-on-once.patch
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]