Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

On Wednesday November 23, [email protected] wrote:
> On Wed, Nov 23, 2005 at 04:31:14AM -0800, Lever, Charles wrote:
> > so i don't remember why you are removing xdr_decode_string.  are we sure
> > that no-one will need this functionality in the future?  it is harmless
> > to remove today, but i wonder if someone is just going to add it back
> > sometime.
> 
> It's unused and you said:
>   the only harmless change i see below is removing xdr_decode_string().
> 

As 'xdr_decode_string' (sometimes) modifies the buffer that it is
decoding, I don't think it's usage should be encouraged.  If it is no
longer in use, then I fully support and encourage removing it.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • RE: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()
    • From: "Lever, Charles" <[email protected]>
  • Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [git pull 09/14] Uinput: add UI_SET_SWBIT ioctl
• Next by Date: Re: [patch] SMP alternatives
• Previous by thread: Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()
• Next by thread: RE: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]