Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Adrian Bunk wrote:
[...]
> There's no need to free cache at this point, and it's getting free'd 
> later.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c.old	2005-11-20 22:08:57.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c	2005-11-21 00:49:38.000000000 +0100
> @@ -2131,7 +2131,6 @@
>  			   req->req.length)) {
>  		csr1212_release_keyval(fi->csr1212_dirs[dr]);
>  		fi->csr1212_dirs[dr] = NULL;
> -		CSR1212_FREE(cache);
>  		ret = -EFAULT;
>  	} else {
>  		cache->len = req->req.length;

This looks OK to me. But there seems to be another bug. I think the line

	kfree(cache);

after the if and else blocks has to be replaced by

	CSR1212_FREE(cache);

--
Stefan Richter
-=====-=-=-= =-== =-=-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/