[2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference

The coverity checker spotted that this was a NULL pointer dereference in 
the "if (copy_from_user(...))" case.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c.old	2005-11-20 22:08:57.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c	2005-11-20 22:09:34.000000000 +0100
@@ -2166,7 +2166,8 @@
 			}
 		}
 	}
-	kfree(cache->filled_head);
+	if(cache->filled_head)
+		kfree(cache->filled_head);
 	kfree(cache);
 
 	if (ret >= 0) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
    • From: Jesper Juhl <[email protected]>
  • Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
    • From: Dave Jones <[email protected]>
  • Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
    • From: Jody McIntyre <[email protected]>

• Prev by Date: [2.6 patch] video/matrox/matroxfb_misc.c: remove dead code
• Next by Date: Re: [PATCH 2/5] I2O: SPARC fixes
• Previous by thread: [2.6 patch] video/matrox/matroxfb_misc.c: remove dead code
• Next by thread: Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]