Re: [PATCH 4/5] slab: extract slab order calculation to separate function

Manfred Spraul <[email protected]> wrote:
>
> >+	} else
>  >+		left_over = calculate_slab_order(cachep, size, align, flags);
>  >  
>  >
> 
>  I usually add braces in this case: If braces are necessary for either 
>  the if or the else-clause, then I add braces to both parts.
> 
>  Could be applied as is, or I could write a patch with both changes.
>  Andrew - what do you prefer?

I normally add the braces in both legs of the `if' if one leg needs them. 
But it looks crappy either way, so whatever.  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 4/5] slab: extract slab order calculation to separate function
    • From: Pekka Enberg <[email protected]>
  • Re: [PATCH 4/5] slab: extract slab order calculation to separate function
    • From: Manfred Spraul <[email protected]>

• Prev by Date: Re: Sun's ZFS and Linux
• Next by Date: Does Linux support powering down SATA drives?
• Previous by thread: Re: [PATCH 4/5] slab: extract slab order calculation to separate function
• Next by thread: Re: [PATCH 3/5] slab: extract slabinfo header printing to separate function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]