Re: [PATCH 3/5] slab: extract slabinfo header printing to separate function

Pekka Enberg wrote:

 #ifdef CONFIG_PROC_FS

-static void *s_start(struct seq_file *m, loff_t *pos)
+static inline void print_slabinfo_header(struct seq_file *m)

Why inline? I try to avoid adding inline wherever possible. inline is actually always_inline force_inline compiler_we_know_it_better_this_must_be_inlined. I only use inline in the hot path (kmem_cache_alloc/kmalloc+free) and where I know that lots of code will be optimized away due to constant propagation. In this case, there is no reason to force the compiler to inline the function, thus I wouldn't add an inline.

--
   Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/5] slab: extract slabinfo header printing to separate function
    • From: Pekka Enberg <[email protected]>

• References:
  • [PATCH 3/5] slab: extract slabinfo header printing to separate function
    • From: Pekka Enberg <[email protected]>

• Prev by Date: Re: PCI error on x86_64 2.6.13 kernel
• Next by Date: Re: [PATCH 1/5] slab: rename obj_reallen to obj_size
• Previous by thread: Re: [PATCH 4/5] slab: extract slab order calculation to separate function
• Next by thread: Re: [PATCH 3/5] slab: extract slabinfo header printing to separate function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]