On Mon, 14 Nov 2005 08:26:45 +1100, Neil Brown <[email protected]> wrote: > On Sunday November 13, [email protected] wrote: > > > > Kernel is 2.6.14-mm2. > > This is an x86 box, why does it compile raid6altivec*.c ? I suppose it > > does not generate any code, because of some #ifdef magic, but why does > > it build them anyways ? Looks a bit strange. > > It's probably just easier that way. > I guess you could do the following, but I'm not sure that it is really > worth it. > > NeilBrown > > Signed-off-by: Neil Brown <[email protected]> > > diff ./drivers/md/Makefile~current~ ./drivers/md/Makefile > --- ./drivers/md/Makefile~current~ 2005-11-14 08:13:43.000000000 +1100 > +++ ./drivers/md/Makefile 2005-11-14 08:23:29.000000000 +1100 > @@ -8,12 +8,15 @@ dm-multipath-objs := dm-hw-handler.o dm- > dm-snapshot-objs := dm-snap.o dm-exception-store.o > dm-mirror-objs := dm-log.o dm-raid1.o > md-mod-objs := md.o bitmap.o > +raid6-$(CONFIG_ALTIVEC) := \ > + raid6altivec1.o raid6altivec2.o raid6altivec4.o \ > + raid6altivec8.o > +raid6-$(CONFIG_X86) := raid6mmx.o raid6sse1.o > +raid6-$(CONFIG_X86_64) := raid6sse2.o > raid6-objs := raid6main.o raid6algos.o raid6recov.o raid6tables.o \ > raid6int1.o raid6int2.o raid6int4.o \ > raid6int8.o raid6int16.o raid6int32.o \ > - raid6altivec1.o raid6altivec2.o raid6altivec4.o \ > - raid6altivec8.o \ > - raid6mmx.o raid6sse1.o raid6sse2.o > + $(raid6-y) Err, if I did not misundertood it, raid6-y would mean 'objects for building raid6 in kernel', versus 'raid6-m', for objects for build as a module ? Would not this be better: --- Makefile.orig 2005-11-13 23:14:48.000000000 +0100 +++ Makefile 2005-11-13 23:28:05.000000000 +0100 @@ -8,12 +8,21 @@ dm-snapshot-objs := dm-snap.o dm-exception-store.o dm-mirror-objs := dm-log.o dm-raid1.o md-mod-objs := md.o bitmap.o + + +ifeq ($(CONFIG_ALTIVEC),y) +raid6-vec-objs := \ + raid6altivec1.o raid6altivec2.o \ + raid6altivec4.o raid6altivec8.o +endif +ifeq ($(CONFIG_X86),y) +raid6-vec-objs := \ + raid6mmx.o raid6sse1.o raid6sse2.o +endif raid6-objs := raid6main.o raid6algos.o raid6recov.o raid6tables.o \ raid6int1.o raid6int2.o raid6int4.o \ raid6int8.o raid6int16.o raid6int32.o \ - raid6altivec1.o raid6altivec2.o raid6altivec4.o \ - raid6altivec8.o \ - raid6mmx.o raid6sse1.o raid6sse2.o + $(raid6-vec-objs) hostprogs-y := mktables # Note: link order is important. All raid personalities -- J.A. Magallon <jamagallon()able!es> \ Software is like sex: werewolf!able!es \ It's better when it's free Mandriva Linux release 2006.1 (Cooker) for i586 Linux 2.6.14-jam2 (gcc 4.0.2 (4.0.2-1mdk for Mandriva Linux release 2006.1))
Attachment:
signature.asc
Description: PGP signature
- References:
- x86 building altivec for raid ?
- From: "J.A. Magallon" <[email protected]>
- Re: x86 building altivec for raid ?
- From: Neil Brown <[email protected]>
- x86 building altivec for raid ?
- Prev by Date: Re: [RFT][PATCH 2/3] swsusp: introduce the swap map structure
- Next by Date: Re: [PATCH] plugsched - update Kconfig-1
- Previous by thread: Re: x86 building altivec for raid ?
- Next by thread: Linux Kernel -KLG extraversion
- Index(es):
 |