Hi,
On Sunday, 13 of November 2005 22:16, Pavel Machek wrote:
> Hi!
>
> > This patch introduces the swap map structure that can be used by swsusp for
> > keeping tracks of data pages written to the swap. The structure itself is
> > described in a comment within the patch.
> >
> > The overall idea is to reduce the amount of metadata written to the swap
> > and to write and read the image pages sequentially, in a file-alike way.
> > This makes the swap-handling part of swsusp fairly independent of its
> > snapshot-handling part and will hopefully allow us to completely
> > separate these two parts in the future.
> >
> > Signed-off-by: Rafael J. Wysocki <[email protected]>
>
> ACK.
>
> > +struct swap_map_handle {
> > + void *tfm; /* Needed for the encryption */
> > + struct swap_map_page *cur;
> > + unsigned int k;
> > +};
>
> I thought you killed encryption in 1/3?
And I thought so, but this one apparently survived ...
> > @@ -33,6 +33,9 @@
> >
> > #include "power.h"
> >
> > +struct pbe *pagedir_nosave = NULL;
> > +unsigned int nr_copy_pages = 0;
> > +
> > #ifdef CONFIG_HIGHMEM
> > struct highmem_page {
> > char *data;
>
> You don't need to initialize to zero/NULL.
OK
I'll make the changes and post for inclusion into -mm in a couple of days.
Greetings,
Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
