Pekka J Enberg wrote:
> On Mon, 7 Nov 2005, Roland Dreier wrote:
>
>
>> > * Replace a constant (4096) with what it represents (PAGE_SIZE)
>>
>>This seems dangerous. I don't pretend to understand the slab code,
>>but the current code works on architectures with PAGE_SIZE != 4096.
>>Are you sure this change is correct?
>
>
> Looks ok to me except that it should be a separate patch (it is not a
> trivial cleanup because it changes how the code works).
>
> Pekka
That's very reasonable, Pekka. I will respin 4/8 without that change and
add a 9/8 that is JUST that one change.
Thank you both for the review and comments!
-Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
