Re: [PATCH 4/8] Cleanup kmem_cache_create()

    > * Replace a constant (4096) with what it represents (PAGE_SIZE)

This seems dangerous.  I don't pretend to understand the slab code,
but the current code works on architectures with PAGE_SIZE != 4096.
Are you sure this change is correct?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 4/8] Cleanup kmem_cache_create()
  - From: Christoph Lameter <[email protected]>
- Re: [PATCH 4/8] Cleanup kmem_cache_create()
  - From: Pekka J Enberg <[email protected]>

References:
- [PATCH 0/8] Cleanup slab.c
  - From: Matthew Dobson <[email protected]>
- [PATCH 4/8] Cleanup kmem_cache_create()
  - From: Matthew Dobson <[email protected]>

Prev by Date: Re: Database regression due to scheduler changes ?
Next by Date: Re: + cpu-hotplug-fix-locking-in-cpufreq-drivers-fix.patch added to -mm tree
Previous by thread: [PATCH 4/8] Cleanup kmem_cache_create()
Next by thread: Re: [PATCH 4/8] Cleanup kmem_cache_create()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]