Re: [PATCH] [MMC] wbsd pnp suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 08 November 2005 01:57, Pierre Ossman wrote:
> Andrew Morton wrote:
> > Pierre Ossman <[email protected]> wrote: 
> >> +	if (host->config != 0)
> >> +	{
> >> +		if (!wbsd_chip_validate(host))
> >> +		{
> > 
> > Like:
> > 
> > 	if (host->config != 0) {
> > 		if (!wbsd_chip_validate(host)) {
> > 
> > please.
> > 
> 
> We had this discussion the last patch for this driver. It's horribly 
> wrong when it comes to coding style so keeping patches in the same style 
> as the rest of the driver is the lesser evil (IMHO).
>

Aside from unusual brace placement it does not look too bad. How about
running it through Lindent to fix it once and for all?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux