Re: [PATCH] [MMC] wbsd pnp suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote:
Pierre Ossman <[email protected]> wrote:
Allow the wbsd driver to use the new suspend/resume functions added to
the PnP layer.


Doesn't Russell handle mmc stuff?


Yup. But this needs the PnP suspend stuff in your patch set.

-static int wbsd_suspend(struct device *dev, pm_message_t state)
+static int wbsd_suspend(struct wbsd_host *host, pm_message_t state)
+{
+	BUG_ON(host == NULL);
+
+	return mmc_suspend_host(host->mmc, state);
+}

There's not much point in this BUG_ON.  If host==0 then we'll get a
perfectly good oops in the next statement - it's just as informative.


I suppose. I just have a tendency to scatter assertions all over the place. :)

+	if (host->config != 0)
+	{
+		if (!wbsd_chip_validate(host))
+		{

Like:

	if (host->config != 0) {
		if (!wbsd_chip_validate(host)) {

please.


We had this discussion the last patch for this driver. It's horribly wrong when it comes to coding style so keeping patches in the same style as the rest of the driver is the lesser evil (IMHO).

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux