Re: [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite

Andrew Morton wrote:

Michael Krufky <[email protected]> wrote:

+static int tdvs_tua6034_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params)
+{
+	struct dvb_bt8xx_card *card = (struct dvb_bt8xx_card *) fe->dvb->priv;

The cast of a void* is unneeded.  It's actually undesirable: if someone
were to convert the thing-being-casted to some other scalar type, the cast
would prevent the desired compiler warning.

Alexey Dobriyan wrote:

Please, also

	struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
			   ^				       ^

Both of these problems are all over dvb-kernel... We'll fix it up.

Thanks,

Michael Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite
    • From: Michael Krufky <[email protected]>
  • Re: [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Parallel ATA with libata status with the patches I'm working on
• Next by Date: RE: processor module locks up hyperthreading enabled machine
• Previous by thread: Re: [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite
• Next by thread: [PATCH 07/37] dvb: pluto2: Removed unavoidable error message and related code
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]