Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation

On Tuesday 01 November 2005 01:04, Ian Wienand wrote:
> On Tue, Nov 01, 2005 at 12:55:31AM -0500, Dmitry Torokhov wrote:
> > Now you are leaking memory if something else fails... FOr example when
> > chip is not present.
> 
> Good point.  I guess the original comment is because the final
> dmasound_init() can fail but we'll still have all sorts of memory,
> irq's and io that aren't cleaned up.  So your previous patch probably
> introduces the least problems.
>

Have you tried it by any chance? I'd feel much better pushing it upstream
knowing that it was tested at least once...

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Ian Wienand <[email protected]>

References:
- [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Ian Wienand <[email protected]>
- Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Dmitry Torokhov <[email protected]>
- Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Ian Wienand <[email protected]>

Prev by Date: [PATCH] Simpler signal-exit concurrency handling
Next by Date: Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
Previous by thread: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
Next by thread: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]