Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation

On Tuesday 01 November 2005 00:50, Ian Wienand wrote:
> On Tue, Nov 01, 2005 at 12:14:56AM -0500, Dmitry Torokhov wrote:
> > It seems that the change is pretty straightforward... Could you please try
> > this one?
> 
> Ahh, ok!  I thought that that comment meant it was deliberately
> ignoring the return of input_register_device (by which time it's got
> memory, irq's, io, etc), but now I see it's void anyway.  So why not
> just move the setup right to the top?
>

Now you are leaking memory if something else fails... FOr example when
chip is not present.


-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Ian Wienand <[email protected]>

References:
- [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Ian Wienand <[email protected]>
- Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Dmitry Torokhov <[email protected]>
- Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
  - From: Ian Wienand <[email protected]>

Prev by Date: [PATCH] Fixes for RCU handling of sighand_struct
Next by Date: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
Previous by thread: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
Next by thread: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]