On Wed, 2005-10-26 at 21:37 -0400, Steven Rostedt wrote: > On Wed, 2005-10-26 at 18:22 -0700, john stultz wrote: > > > > > I don't know if that would really fix it, because ideally you want to > > read the prev_mono_time at the same point you calculate the time inside > > the read lock'ed critical section. > > Ideally yes, but this is just for debugging, so as long as prev is read > before now, this should prevent false positives due to ordering. Ah, you're right, good point! I was being overly paranoid. So as long as the writing of the 64bit value is atomic (which it isn't, but that can be fixed) there shouldn't be ordering problems w/ your patch. And sure enough, it seems to take care of the warnings on my box. Great debugging job! -john - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: 2.6.14-rc4-rt7
- From: Steven Rostedt <[email protected]>
- Re: 2.6.14-rc4-rt7
- References:
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: john stultz <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: john stultz <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: George Anzinger <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: George Anzinger <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: George Anzinger <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Rui Nuno Capela <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: William Weston <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Steven Rostedt <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: john stultz <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Steven Rostedt <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: john stultz <[email protected]>
- Re: 2.6.14-rc4-rt7
- From: Steven Rostedt <[email protected]>
- Re: 2.6.14-rc4-rt7
- Prev by Date: Re: 2.6.14-rc5 (i386) + TSC, how to disable? time drift
- Next by Date: [patch] optimize activate_task()
- Previous by thread: Re: 2.6.14-rc4-rt7
- Next by thread: Re: 2.6.14-rc4-rt7
- Index(es):
 |