On Wed, 2005-10-26 at 18:22 -0700, john stultz wrote: > > I don't know if that would really fix it, because ideally you want to > read the prev_mono_time at the same point you calculate the time inside > the read lock'ed critical section. Ideally yes, but this is just for debugging, so as long as prev is read before now, this should prevent false positives due to ordering. But I'm not sure if my patch did anything regardless, since the prev_mono_time is a cpu variable, and the get_cpu and put_cpu implement a preempt_disable, so unless an interrupt is changing it, it should be OK. -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: 2.6.14-rc4-rt7
- From: john stultz <johnstul@us.ibm.com>
- Re: 2.6.14-rc4-rt7
- References:
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <mingo@elte.hu>
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <mingo@elte.hu>
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
- Re: 2.6.14-rc4-rt7
- From: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
- Re: 2.6.14-rc4-rt7
- From: john stultz <johnstul@us.ibm.com>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <mingo@elte.hu>
- Re: 2.6.14-rc4-rt7
- From: john stultz <johnstul@us.ibm.com>
- Re: 2.6.14-rc4-rt7
- From: George Anzinger <george@mvista.com>
- Re: 2.6.14-rc4-rt7
- From: Ingo Molnar <mingo@elte.hu>
- Re: 2.6.14-rc4-rt7
- From: George Anzinger <george@mvista.com>
- Re: 2.6.14-rc4-rt7
- From: George Anzinger <george@mvista.com>
- Re: 2.6.14-rc4-rt7
- From: Rui Nuno Capela <rncbc@rncbc.org>
- Re: 2.6.14-rc4-rt7
- From: William Weston <weston@lysdexia.org>
- Re: 2.6.14-rc4-rt7
- From: Steven Rostedt <rostedt@goodmis.org>
- Re: 2.6.14-rc4-rt7
- From: john stultz <johnstul@us.ibm.com>
- Re: 2.6.14-rc4-rt7
- From: Steven Rostedt <rostedt@goodmis.org>
- Re: 2.6.14-rc4-rt7
- From: john stultz <johnstul@us.ibm.com>
- Re: 2.6.14-rc4-rt7
- Prev by Date: Re: 2.6.14-rc4-rt7
- Next by Date: Re: [discuss] [rfc] x86_64: Kconfig changes for NUMA
- Previous by thread: Re: 2.6.14-rc4-rt7
- Next by thread: Re: 2.6.14-rc4-rt7
- Index(es):
![]() |