Re: [PATCH] fix vgacon blanking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 20, 2005 at 11:23:01PM +0200, Bodo Eggert wrote:
> Pozsar Balazs <[email protected]> wrote:
> 
> > This patch fixes a long-standing vgacon bug: characters with the bright
> > bit set were left on the screen and not blacked out.
> > All I did was that I lookuped up some examples on the net about setting
> > the vga palette, and added the call missing from the linux kernel, but
> > included in all other ones. It works for me.
> 
> This is strange, since according to my documentation, the value should have
> been initialized to 0xff and never been changed. Can you test setting this
> value during initialisation (around line 259, if I read correctly) instead?
> I don't know if I can test it myself soon enough.
> 
> (I'm not the maintainer, I just happen to have some documentation).

Maybe I can test it tomorrow. But as the posted patch work as-is, cannot 
do any harm because it just makes sure the register is set as it should 
be, and we are talking about a not-so-often called slowpath, I think it 
should just be merged and get forgotten, without making a big hassle 
making around it :)
On the other side, as this bug is a little annoyment, it can be tested 
in -mm until 2.6.15 or so. I have the cure now, so I'm happy with it :)


-- 
pozsy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux